Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sdkv3): migrate ssm client (WIP) #6137

Draft
wants to merge 18 commits into
base: feature/sdkv3
Choose a base branch
from

Conversation

Hweinstock
Copy link
Contributor

@Hweinstock Hweinstock commented Dec 3, 2024

reliant on work in: #6097

Problem

There is a lot of duplicate code across the sdk clients. Additionally, we want to only construct the clients once (per wrapper), and have these clients call destroy.

Solution

  • rename clients to wrappers to avoid confusion between our clients and sdk clients.
  • create abstract class to minimize code dupe.
  • cache sdk clients on creation within the wrappers.
  • migrate ssm client to sdkv3, using new common wrapper class.

TODO: undo local changes to streaming client, generate client with more recent dependencies.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Hweinstock Hweinstock changed the base branch from master to feature/sdkv3 December 3, 2024 22:18
@Hweinstock Hweinstock changed the title refactor(sdkv3): migrate ssm client refactor(sdkv3): migrate ssm client (WIP) Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant